slapin/qtmultimedia
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

BlackBerry: Pass encoded URLs to mm renderer

Browse Source 
MM renderer expects (remote) URLs to be percent encoded.

Change-Id: Ib7429cbeb3b7aa6baba99419d8b101a712ab4881
Reviewed-by: Rafael Roquetto <rafael.roquetto@kdab.com>
Reviewed-by: Thomas McGuire <thomas.mcguire@kdab.com>
This commit is contained in:
Bernd Weimer
2013-08-27 10:39:31 +02:00
committed by The Qt Project
parent a2f078f108
commit 13a53a5056
2 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
src/plugins/blackberry/mediaplayer/bbmediaplayercontrol.cpp
View File

@@ -137,7 +137,7 @@ void BbMediaPlayerControl::closeConnection()
} }
} }
QString BbMediaPlayerControl::resourcePathForUrl(const QUrl &url) QByteArray BbMediaPlayerControl::resourcePathForUrl(const QUrl &url)
{ {
// If this is a local file, mmrenderer expects the file:// prefix and an absolute path. // If this is a local file, mmrenderer expects the file:// prefix and an absolute path.
// We treat URLs without scheme as local files, most likely someone just forgot to set the // We treat URLs without scheme as local files, most likely someone just forgot to set the
@@ -149,7 +149,7 @@ QString BbMediaPlayerControl::resourcePathForUrl(const QUrl &url)
else else
relativeFilePath = url.path(); relativeFilePath = url.path();
const QFileInfo fileInfo(relativeFilePath); const QFileInfo fileInfo(relativeFilePath);
return QStringLiteral("file://") + fileInfo.absoluteFilePath(); return QFile::encodeName(QStringLiteral("file://") + fileInfo.absoluteFilePath());
// QRC, copy to temporary file, as mmrenderer does not support resource files // QRC, copy to temporary file, as mmrenderer does not support resource files
} else if (url.scheme() == QStringLiteral("qrc")) { } else if (url.scheme() == QStringLiteral("qrc")) {
@@ -159,17 +159,17 @@ QString BbMediaPlayerControl::resourcePathForUrl(const QUrl &url)
QUuid::createUuid().toString() + QStringLiteral(".") + QUuid::createUuid().toString() + QStringLiteral(".") +
resourceFileInfo.suffix(); resourceFileInfo.suffix();
if (!QFile::copy(qrcPath, m_tempMediaFileName)) { if (!QFile::copy(qrcPath, m_tempMediaFileName)) {
const QString errorMsg = const QString errorMsg = QString("Failed to copy resource file to temporary file "
QString("Failed to copy resource file to temporary file %1 for playback").arg(m_tempMediaFileName); "%1 for playback").arg(m_tempMediaFileName);
qDebug() << errorMsg; qDebug() << errorMsg;
emit error(0, errorMsg); emit error(0, errorMsg);
return QString(); return QByteArray();
} }
return m_tempMediaFileName; return QFile::encodeName(m_tempMediaFileName);
// HTTP or similar URL, use as-is // HTTP or similar URL
} else { } else {
return url.toString(); return url.toEncoded();
} }
} }
@@ -195,14 +195,14 @@ void BbMediaPlayerControl::attach()
return; return;
} }
const QString resourcePath = resourcePathForUrl(m_media.canonicalUrl()); const QByteArray resourcePath = resourcePathForUrl(m_media.canonicalUrl());
if (resourcePath.isEmpty()) { if (resourcePath.isEmpty()) {
detach(); detach();
return; return;
} }
if (mmr_input_attach(m_context, QFile::encodeName(resourcePath), "track") != 0) { if (mmr_input_attach(m_context, resourcePath.constData(), "track") != 0) {
emitMmError(QString("mmr_input_attach() for %1 failed").arg(resourcePath)); emitMmError(QStringLiteral("mmr_input_attach() failed for ") + QString(resourcePath));
setMediaStatus(QMediaPlayer::InvalidMedia); setMediaStatus(QMediaPlayer::InvalidMedia);
detach(); detach();
return; return;

2
src/plugins/blackberry/mediaplayer/bbmediaplayercontrol.h
View File

@@ -109,7 +109,7 @@ private Q_SLOTS:
void continueLoadMedia(); void continueLoadMedia();
private: private:
QString resourcePathForUrl(const QUrl &url); QByteArray resourcePathForUrl(const QUrl &url);
void openConnection(); void openConnection();
void closeConnection(); void closeConnection();
void attach(); void attach();