slapin/qtmultimedia
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix uninitialized memory reads in MFAudioDecoderControl.

Browse Source 
Initialize all members in constructor.

[W] UMR: Uninitialized memory read in MFAudioDecoderControl::handleMediaSourceReady(void) {1 occurrence}
         Error location
            MFAudioDecoderControl::handleMediaSourceReady(void) [c:\qt\qt-55-32\qt-55-32\qtmultimedia\src\plugins\wmf\decoder\mfaudiodecodercontrol.cpp:254]
[W] UMR: Uninitialized memory read in MFAudioDecoderControl::activatePipeline(void) {1 occurrence}
            MFAudioDecoderControl::activatePipeline(void) [c:\qt\qt-55-32\qt-55-32\qtmultimedia\src\plugins\wmf\decoder\mfaudiodecodercontrol.cpp:289]

Task-number: QTBUG-40571
Change-Id: I6f97cf72284f739ceffcf65162963d00de979ea2
Reviewed-by: Yoann Lopes <yoann.lopes@theqtcompany.com>
This commit is contained in:
Friedemann Kleint
2015-03-09 12:31:11 +01:00
parent 7b2178768f
commit 2099a8c3c7
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/wmf/decoder/mfaudiodecodercontrol.cpp
View File

@@ -41,7 +41,11 @@ MFAudioDecoderControl::MFAudioDecoderControl(QObject *parent)
, m_resampler(0) , m_resampler(0)
, m_state(QAudioDecoder::StoppedState) , m_state(QAudioDecoder::StoppedState)
, m_device(0) , m_device(0)
, m_mfInputStreamID(0)
, m_mfOutputStreamID(0)
, m_bufferReady(false) , m_bufferReady(false)
, m_duration(0)
, m_position(0)
, m_loadingSource(false) , m_loadingSource(false)
, m_mfOutputType(0) , m_mfOutputType(0)
, m_convertSample(0) , m_convertSample(0)
@@ -53,8 +57,6 @@ MFAudioDecoderControl::MFAudioDecoderControl(QObject *parent)
qCritical("MFAudioDecoderControl: Failed to create resampler(CLSID_CResamplerMediaObject)!"); qCritical("MFAudioDecoderControl: Failed to create resampler(CLSID_CResamplerMediaObject)!");
return; return;
} }
m_mfInputStreamID = 0;
m_mfOutputStreamID = 0;
m_resampler->AddInputStreams(1, &m_mfInputStreamID); m_resampler->AddInputStreams(1, &m_mfInputStreamID);
connect(m_sourceResolver, SIGNAL(mediaSourceReady()), this, SLOT(handleMediaSourceReady())); connect(m_sourceResolver, SIGNAL(mediaSourceReady()), this, SLOT(handleMediaSourceReady()));