slapin/qtmultimedia
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Optimize QMediaPlaylistPrivate::readItems()

Browse Source 
When reading playlist items from a file, pass them to the playlist
backend all at once rather than one by one. This might be faster
depending on the implementation.

Task-number: QTBUG-54849
Change-Id: I57acdc68604ee56fe5d7615ba0a72655e668443f
Reviewed-by: Christian Stromme <christian.stromme@qt.io>
This commit is contained in:
Yoann Lopes
2016-08-18 14:18:59 +02:00
parent 6d95682d7f
commit 6817067ff7
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/multimedia/playback/qmediaplaylist.cpp
View File

@@ -428,10 +428,12 @@ bool QMediaPlaylist::clear()
bool QMediaPlaylistPrivate::readItems(QMediaPlaylistReader *reader) bool QMediaPlaylistPrivate::readItems(QMediaPlaylistReader *reader)
{ {
while (!reader->atEnd()) QList<QMediaContent> items;
playlist()->addMedia(reader->readItem());
return true; while (!reader->atEnd())
items.append(reader->readItem());
return playlist()->addMedia(items);
} }
bool QMediaPlaylistPrivate::writeItems(QMediaPlaylistWriter *writer) bool QMediaPlaylistPrivate::writeItems(QMediaPlaylistWriter *writer)