slapin/qtmultimedia
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix a possible crash in QSoundEffect.

Browse Source 
pa_stream_cork may fail, and pa_operation_unref won't handle that gracefully, so
check the return value before unreffing.

Done-with: Vesa-Matti Hartikainen
Change-Id: If789e37a13f85487c79dd8a03a7ca3624b1412d2
Reviewed-by: Shawn Rutledge <shawn.rutledge@digia.com>
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
This commit is contained in:
Robin Burchell
2012-11-07 23:23:45 +01:00
committed by The Qt Project
parent c042e61a77
commit a73dfa7c63
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/multimedia/audio/qsoundeffect_pulse_p.cpp
View File

@@ -838,7 +838,9 @@ void QSoundEffectPrivate::playSample()
#endif
Q_ASSERT(m_pulseStream);
Q_ASSERT(pa_stream_get_state(m_pulseStream) == PA_STREAM_READY);
pa_operation_unref(pa_stream_cork(m_pulseStream, 0, 0, 0));
pa_operation *o = pa_stream_cork(m_pulseStream, 0, 0, 0);
if (o)
pa_operation_unref(o);
}
void QSoundEffectPrivate::stop()