slapin/qtmultimedia
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Resource leak fixed

Browse Source 
CameraBinV4LImageProcessing::setParameter was leaking the resource fd
in some cases in the switch using return instead of break.

Change-Id: Ie56eaf4cf1d1b7531094c321f49a818632985628
Reviewed-by: Yoann Lopes <yoann.lopes@qt.io>
This commit is contained in:
Jesus Fernandez
2016-05-23 17:28:46 +02:00
parent 6f28963c50
commit ab940d8fe9
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/plugins/gstreamer/camerabin/camerabinv4limageprocessing.cpp
View File

@@ -194,8 +194,10 @@ void CameraBinV4LImageProcessing::setParameter(
const QCameraImageProcessing::WhiteBalanceMode m = const QCameraImageProcessing::WhiteBalanceMode m =
value.value<QCameraImageProcessing::WhiteBalanceMode>(); value.value<QCameraImageProcessing::WhiteBalanceMode>();
if (m != QCameraImageProcessing::WhiteBalanceAuto if (m != QCameraImageProcessing::WhiteBalanceAuto
&& m != QCameraImageProcessing::WhiteBalanceManual) && m != QCameraImageProcessing::WhiteBalanceManual) {
qt_safe_close(fd);
return; return;
}
control.value = (m == QCameraImageProcessing::WhiteBalanceAuto) ? true : false; control.value = (m == QCameraImageProcessing::WhiteBalanceAuto) ? true : false;
} }
@@ -214,6 +216,7 @@ void CameraBinV4LImageProcessing::setParameter(
break; break;
default: default:
qt_safe_close(fd);
return; return;
} }