slapin/qtmultimedia
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fixed major mem leak of unfreed GstTagList when playing ogg files.

Browse Source 
Could cause serious leak if ogg files contain coverart image.
Should use gst_tag_list_fee to free the used taglist.

Change-Id: I8f7b799729b84ad9a2ca45bc3e31f37a987a5885
Reviewed-by: Michael Goddard <michael.goddard@nokia.com>
This commit is contained in:
bigbearzhu
2012-03-30 16:07:49 +10:00
committed by Qt by Nokia
parent 37627f7680
commit df3f5d790f
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/gstreamer/mediaplayer/qgstreamerplayersession.cpp
View File

@@ -961,6 +961,7 @@ bool QGstreamerPlayerSession::processBusMessage(const QGstreamerMessage &message
gst_message_parse_tag(gm, &tag_list); gst_message_parse_tag(gm, &tag_list);
m_tags.unite(QGstUtils::gstTagListToMap(tag_list)); m_tags.unite(QGstUtils::gstTagListToMap(tag_list));
gst_tag_list_free(tag_list);
//qDebug() << m_tags; //qDebug() << m_tags;
emit tagsChanged(); emit tagsChanged();
@@ -1316,6 +1317,7 @@ void QGstreamerPlayerSession::getStreamsInfo()
//qDebug() << "language for setream" << i << QString::fromUtf8(languageCode); //qDebug() << "language for setream" << i << QString::fromUtf8(languageCode);
g_free (languageCode); g_free (languageCode);
gst_tag_list_free(tags);
} }
m_streamProperties.append(streamProperties); m_streamProperties.append(streamProperties);